]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
popupMenu: Change the position of the icon in PopupImageMenuItem
authorMario Sanchez Prada <mario@endlessm.com>
Thu, 4 May 2017 17:09:39 +0000 (18:09 +0100)
committerMario Sanchez Prada <mario@endlessm.com>
Tue, 9 May 2017 17:32:23 +0000 (18:32 +0100)
We are moving the icon to be added before the text instead of after,
which is consistent with other menu items in other popup menus, such
as the ones in the system indicator's popup menu.

https://bugzilla.gnome.org/show_bug.cgi?id=782166

js/ui/popupMenu.js

index 17a5a911a735f87683023685b345f9f13016931f..fbe409ee2505fb0db65aaf7f4903ae3ef9e077c5 100644 (file)
@@ -394,10 +394,10 @@ const PopupImageMenuItem = new Lang.Class({
     _init: function (text, icon, params) {
         this.parent(params);
 
-        this.label = new St.Label({ text: text });
-        this.actor.add_child(this.label);
         this._icon = new St.Icon({ style_class: 'popup-menu-icon' });
         this.actor.add_child(this._icon, { align: St.Align.END });
+        this.label = new St.Label({ text: text });
+        this.actor.add_child(this.label);
         this.actor.label_actor = this.label;
 
         this.setIcon(icon);